Browse Source

culture-media: improvements

osm-qa
parent
commit
32e05145bb
  1. 34
      culture-media.yaml

34
culture-media.yaml

@ -5,16 +5,27 @@ query:
feature:
pre: |
{% set color = 'red' %}
{% set str = 'No image, wikimedia_commons or wikidata' %}
{% if tags.wikidata %}
{% set color = 'blue' %}
{% set str = 'has wikidata tag' %}
{% set wikidata = tags.wikidata|wikidataEntity %}
{% if wikidata.claims.P31[0].mainsnak.datavalue.value.id in ['Q5'] %}
{% set color = 'magenta' %}
{% set str = "wikidata points to a human, should most likely be 'subject:wikidata'" %}
{% endif %}
{% elseif tags.wikimedia_commons or tags.image %}
{% set color = 'cyan' %}
{% endif %}
{% set str = tags.wikimedia_commons ? 'has wikimedia_commons tag' : 'has image tag' %}
{% if tags.wikidata %}
{% set wikidata = tags.wikidata|wikidataEntity %}
{% if wikidata.claims.P31[0].mainsnak.datavalue.value.id in ['Q5'] %}{% set color = 'magenta' %}{% endif %}
{% endif %}
body: |
{{ str }}
description: |
{% if tags.historic and tags.historic != 'yes' %}
{{ tagTransList('historic', tags.historic) }}
@ -56,20 +67,23 @@ info: |
</tr>
<tr>
<td>
{{ markerCircle({ fillColor: 'cyan' })|raw }}
{{ markerCircle({ fillColor: 'magenta' })|raw }}
</td>
<td>image or wikimedia_commons but no wikidata</td>
<td>wikidata tag points to a human, should most likely be 'subject:wikidata'</td>
</tr>
<tr>
<td>
{{ markerCircle({ fillColor: 'blue' })|raw }}
{{ markerCircle({ fillColor: 'cyan' })|raw }}
</td>
<td>has wikidata link</td>
<td>image or wikimedia_commons tag but no wikidata</td>
</tr>
<tr>
<td>
{{ markerCircle({ fillColor: 'magenta' })|raw }}
{{ markerCircle({ fillColor: 'blue' })|raw }}
</td>
<td>wikidata points to a human, should most likely be 'subject:wikidata'</td>
<td>has wikidata tag</td>
</tr>
</table>
This category lists artwork, memorials, historic and heritage protected objects. These should have an <a target="_blank" href="https://wiki.openstreetmap.org/wiki/Key:image">image</a> or <a target="_blank" href="https://wiki.openstreetmap.org/wiki/Key:wikimedia_commons">wikimedia_commons</a> tag, or (even better) a <a target="_blank" href="https://wiki.openstreetmap.org/wiki/Key:wikidata">wikidata</a> tag pointing to the object's entry.<br>
Memorials erroneously often have a wikidata (and wikipedia) tag of the person/event, which should be changed to <a target="_blank" href="https://wiki.openstreetmap.org/wiki/Key:wikidata#Secondary_Wikidata_links">subject:wikidata</a> resp. <a target="_blank" href="https://wiki.openstreetmap.org/wiki/Key:wikipedia#Secondary_Wikipedia_links">subject:wikipedia</a>".
Loading…
Cancel
Save