From 6fc78cb756bfb11335e14cefa2ded45f7d87deef Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stephan=20B=C3=B6sch-Plepelits?= Date: Mon, 29 Jan 2018 14:03:44 +0100 Subject: [PATCH 1/4] bugfix, initState should be declared --- src/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/index.js b/src/index.js index 8c547d82..c6208664 100644 --- a/src/index.js +++ b/src/index.js @@ -33,7 +33,7 @@ require('./image') require('./addCategories') window.onload = function () { - initState = config.defaultView + var initState = config.defaultView map = L.map('map') From b0140475ff28e1830c9590ebe35003b90bcb910e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stephan=20B=C3=B6sch-Plepelits?= Date: Mon, 29 Jan 2018 14:06:40 +0100 Subject: [PATCH 2/4] Use babel/-ify to generate compatible version --- package.json | 30 +++++++++++++++++++++++++++++- 1 file changed, 29 insertions(+), 1 deletion(-) diff --git a/package.json b/package.json index 49e813dd..e68b9ef3 100644 --- a/package.json +++ b/package.json @@ -29,14 +29,42 @@ "sheet-router": "^4.2.3", "weight-sort": "^1.3.0" }, + "browserify": { + "transform": [ + [ + "babelify", + { + "presets": [ + [ + "env", + { + "targets": { + "browsers": [ + "last 2 versions", + "> 0.5%", + "safari >= 7", + "ie >= 11" + ] + } + } + ] + ] + } + ] + ] + }, "scripts": { "test": "echo \"Error: no test specified\" && exit 1", - "build": "browserify -g browserify-css src/index.js -o dist/openstreetbrowser.js", + "build": "browserify -g browserify-css src/index.js -o dist/tmp1.js && babel --presets env dist/tmp1.js > dist/tmp2.js && mv dist/tmp2.js dist/openstreetbrowser.js && rm dist/tmp1.js", "watch": "watchify --debug -g browserify-css src/index.js -o dist/openstreetbrowser.js -v", "prepublish": "npm run build", "lint": "standard src/*.js" }, "devDependencies": { + "babel-cli": "^6.26.0", + "babel-core": "^6.26.0", + "babel-preset-env": "^1.6.1", + "babelify": "^8.0.0", "browserify": "^14.4.0", "browserify-css": "^0.14.0", "standard": "^10.0.2", From 77843c4ea2d56b9f0f7a1e91a9e7ee3411ba0a8e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stephan=20B=C3=B6sch-Plepelits?= Date: Tue, 30 Jan 2018 06:49:08 +0100 Subject: [PATCH 3/4] CategoryOverpass: Bugfix - forgot to bind callback function --- src/CategoryOverpass.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/CategoryOverpass.js b/src/CategoryOverpass.js index f7ad154e..946ce7b3 100644 --- a/src/CategoryOverpass.js +++ b/src/CategoryOverpass.js @@ -317,7 +317,7 @@ CategoryOverpass.prototype.show = function (id, options, callback) { } callback(err, data) - } + }.bind(this) ) } From 95019b56eecbc8dd01aa31ff4740eb8f5ef95046 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stephan=20B=C3=B6sch-Plepelits?= Date: Tue, 30 Jan 2018 06:49:29 +0100 Subject: [PATCH 4/4] ImageLoader: always call with 'new' --- src/ImageLoader.js | 8 -------- src/image.js | 4 ++-- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/src/ImageLoader.js b/src/ImageLoader.js index 05f736bf..d4634092 100644 --- a/src/ImageLoader.js +++ b/src/ImageLoader.js @@ -3,14 +3,6 @@ var wikipedia = require('./wikipedia') var cache = {} function ImageLoader (data) { - if (this === window) { - if (data.id in cache) { - return cache[data.id] - } - - return new ImageLoader(data) - } - this.sources = [] this.found = [] this.data = {} diff --git a/src/image.js b/src/image.js index 95df413f..5ac6be88 100644 --- a/src/image.js +++ b/src/image.js @@ -54,7 +54,7 @@ register_hook('show-details', function (data, category, dom, callback) { l.className = 'loadingIndicator' div.appendChild(l) - var currentLoader = ImageLoader(data) + var currentLoader = new ImageLoader(data) data.detailsImageCounter = {} @@ -124,7 +124,7 @@ register_hook('show-popup', function (data, category, dom, callback) { dom.insertBefore(div, dom.firstChild) - var currentLoader = ImageLoader(data) + var currentLoader = new ImageLoader(data) data.popupImageCounter = {} currentLoader.first({