From 5bfa532a9433dc33f1b283c555567eaefc8c5774 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stephan=20B=C3=B6sch-Plepelits?= <skunk@xover.mud.at>
Date: Sun, 21 Oct 2018 19:15:37 +0200
Subject: [PATCH] CategoryOverpass/Filter: add parameter to url resp. read;
 improve form handling

---
 src/CategoryOverpass.js | 114 +++++++++++++++++++++++++++-------------
 src/categories.js       |  16 +++++-
 2 files changed, 93 insertions(+), 37 deletions(-)

diff --git a/src/CategoryOverpass.js b/src/CategoryOverpass.js
index b7bfdeda..28e29ec6 100644
--- a/src/CategoryOverpass.js
+++ b/src/CategoryOverpass.js
@@ -3,6 +3,8 @@
 var OpenStreetBrowserLoader = require('./OpenStreetBrowserLoader')
 var OverpassLayer = require('overpass-layer')
 var OverpassLayerList = require('overpass-layer').List
+var queryString = require('query-string')
+
 var CategoryBase = require('./CategoryBase')
 var state = require('./state')
 var tabs = require('modulekit-tabs')
@@ -120,6 +122,8 @@ function CategoryOverpass (options, data) {
     this.domFilter = document.createElement('form')
     this.tabFilter.content.appendChild(this.domFilter)
 
+    this.tabFilter.on('select', () => this.formFilter.resize())
+
     for (var k in this.data.filter) {
       let f = this.data.filter[k]
       if ('name' in f && typeof f.name === 'string') {
@@ -156,38 +160,12 @@ function CategoryOverpass (options, data) {
     )
     this.formFilter.show(this.domFilter)
     this.formFilter.onchange = function () {
-      var data = this.formFilter.get_data()
-
-      this.additionalFilter = []
-      for (var k in data) {
-        if (data[k] === null) {
-          continue
-        }
+      let param = JSON.parse(JSON.stringify(this.formFilter.get_data()))
 
-        var d = this.data.filter[k]
+      this._applyParam(param)
 
-        var v  = {
-          key: k,
-          value: data[k],
-          op: '='
-        }
-
-        if ('op' in d) {
-          if (d.op === 'has_key_value') {
-            v = {
-              key: data[k],
-              op: 'has_key'
-            }
-          } else {
-            v.op = d.op
-          }
-        }
-
-        this.additionalFilter.push(v)
-      }
-
-      this.layer.options.queryOptions.filter = this.additionalFilter
       this.layer.check_update_map()
+      state.update()
     }.bind(this)
   }
 
@@ -218,7 +196,23 @@ function CategoryOverpass (options, data) {
         state.categories = ''
       }
 
-      state.categories += this.id
+      let id = this.id
+
+      if (this.formFilter) {
+        let param = JSON.parse(JSON.stringify(this.formFilter.get_data()))
+
+        for (var k in param) {
+          if (!param[k]) {
+            delete param[k]
+          }
+        }
+
+        if (param && Object.keys(param).length) {
+          id += '[' + queryString.stringify(param) + ']'
+        }
+      }
+
+      state.categories += id
     }
   }.bind(this))
 
@@ -227,8 +221,17 @@ function CategoryOverpass (options, data) {
       return
     }
 
-    var list = state.categories.split(',')
-    if (list.indexOf(this.id) === -1) {
+    let list = state.categories.split(',')
+    let found = list.filter(id => {
+      let m = id.match(/^([0-9A-Z_-]+)(\[(.*)\])/i)
+      if (m) {
+        id = m[1]
+      }
+
+      return id === this.id
+    }).length
+
+    if (!found) {
       this.close()
     }
 
@@ -236,6 +239,45 @@ function CategoryOverpass (options, data) {
   }.bind(this))
 }
 
+CategoryOverpass.prototype.setParam = function (param) {
+  this.formFilter.set_data(param)
+  this._applyParam(param)
+}
+
+CategoryOverpass.prototype._applyParam = function (param) {
+  this.additionalFilter = []
+  for (var k in param) {
+    if (param[k] === null) {
+      continue
+    }
+
+    var d = this.data.filter[k]
+
+    var v  = {
+      key: k,
+      value: param[k],
+      op: '='
+    }
+
+    if ('op' in d) {
+      if (d.op === 'has_key_value') {
+        v = {
+          key: param[k],
+          op: 'has_key'
+        }
+      } else {
+        v.op = d.op
+      }
+    }
+
+    this.additionalFilter.push(v)
+  }
+
+  this.layer.options.queryOptions.filter = this.additionalFilter
+
+  this.tabFilter.select()
+}
+
 CategoryOverpass.prototype.updateAssets = function (div) {
   var imgs = div.getElementsByTagName('img')
   for (var i = 0; i < imgs.length; i++) {
@@ -278,10 +320,6 @@ CategoryOverpass.prototype.load = function (callback) {
 
 CategoryOverpass.prototype.setParentDom = function (parentDom) {
   CategoryBase.prototype.setParentDom.call(this, parentDom)
-
-  if (this.formFilter) {
-    this.formFilter.resize()
-  }
 }
 
 CategoryOverpass.prototype.setMap = function (map) {
@@ -435,6 +473,10 @@ CategoryOverpass.prototype.open = function () {
 
     this.updateInfo()
   }
+
+  if (this.formFilter) {
+    this.formFilter.resize()
+  }
 }
 
 CategoryOverpass.prototype.updateInfo = function () {
diff --git a/src/categories.js b/src/categories.js
index 4c6c5152..c7615b68 100644
--- a/src/categories.js
+++ b/src/categories.js
@@ -1,3 +1,5 @@
+var queryString = require('query-string')
+
 var OpenStreetBrowserLoader = require('./OpenStreetBrowserLoader')
 
 register_hook('state-apply', function (state) {
@@ -7,6 +9,14 @@ register_hook('state-apply', function (state) {
 
   var list = state.categories.split(',')
   list.forEach(function (id) {
+    let param
+
+    let m = id.match(/^([0-9A-Z_-]+)(\[(.*)\])/i)
+    if (m) {
+      id = m[1]
+      param = queryString.parse(m[3])
+    }
+
     OpenStreetBrowserLoader.getCategory(id, function (err, category) {
       if (err) {
         console.log("Can't load category " + id + ': ', err)
@@ -14,11 +24,15 @@ register_hook('state-apply', function (state) {
       }
 
       if (category) {
-        category.open()
+        if (param) {
+          category.setParam(param)
+        }
 
         if (!category.parentDom) {
           category.setParentDom(document.getElementById('contentListAddCategories'))
         }
+        category.open()
+
       }
     })
   })